[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

[antlarr (Antonio Larrosa Jimenez)]

antlarr added inline comments.

INLINE COMMENTS

> luebking wrote in x11_platform.cpp:206
> PreFrame is (now) effectively "PreFirstGuardedFrame", is it?
> And if invoked at some later point would create the timer and hit the config rewrite every single frame (for the counter is stuck at 0)?
> 
> > rename to avoid bad invocation?
> =================================

Not really, it's expected to be called many times and it checks if it's the first time it was called or not (also, when the counter gets to 0 it's never called anymore)

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3132

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #kwin, #plasma, davidedmundson
Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161024/808e61e8/attachment.html>