[Differential] [Commented On] D3049: Support passing generic QIcon through PlasmaWindow interface

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> apol wrote in plasmawindowmanagement_interface.cpp:386
> maybe worth adding a `if (m_icon == icon) return;`

in theory yes, in practice: operator== doesn't exist for QIcon so all you get is a compile error :-(

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  plasma-window-icon

REVISION DETAIL
  https://phabricator.kde.org/D3049

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, hein, roberts
Cc: apol, roberts, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161015/7cc8c8c5/attachment.html>