[Differential] [Accepted] D3049: Support passing generic QIcon through PlasmaWindow interface

[subdiff (Roman Gilg)]

subdiff accepted this revision.
subdiff added a reviewer: subdiff.
subdiff added a comment.


  Told you, I had problems compiling at first. Works now for unknown reason and icons are displayed together with https://phabricator.kde.org/D3050.

INLINE COMMENTS

> graesslin wrote in plasmawindowmanagement_interface.cpp:386
> in theory yes, in practice: operator== doesn't exist for QIcon so all you get is a compile error :-(

What about comparing QIcon::cacheKey() values?

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  plasma-window-icon

REVISION DETAIL
  https://phabricator.kde.org/D3049

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, hein, roberts, subdiff
Cc: subdiff, apol, roberts, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161016/78dfc0fa/attachment.html>