[Differential] [Changed Subscribers] D3049: Support passing generic QIcon through PlasmaWindow interface

apol (Aleix Pol Gonzalez) noreply at phabricator.kde.org
Fri Oct 14 20:56:43 UTC 2016


apol added inline comments.

INLINE COMMENTS

> plasmawindowmanagement_interface.cpp:386
> +{
> +    m_icon = icon;
> +    setThemedIconName(m_icon.name());

maybe worth adding a `if (m_icon == icon) return;`

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  plasma-window-icon

REVISION DETAIL
  https://phabricator.kde.org/D3049

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, hein, roberts
Cc: apol, roberts, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161014/be722bea/attachment-0001.html>


More information about the Plasma-devel mailing list