[Differential] [Changed Subscribers] D3222: Correctly set i18n suffix in mousemark spinbox.

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> CMakeLists.txt:79
>      WindowSystem
> +    TextWidgets
>      IconThemes

Please move down to the find_package section in line 84. It's a dependency only needed for a config module so it should be together with the other config modules.

> mousemark_config.ui:9-10
>      <y>0</y>
> -    <width>279</width>
> -    <height>178</height>
> +    <width>505</width>
> +    <height>341</height>
>     </rect>

careful here: you opened the UI on a high DPI system and doubled the size.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3222

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161102/a9103ec0/attachment.html>