Review Request 127467: KCM: Fix showing empty stream icon

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127467/#review93884
-----------------------------------------------------------




src/client.cpp (line 62)
<https://git.reviewboard.kde.org/r/127467/#comment63959>

    I'm not sure having hardcoded special cases in c++ for broken applications (hello chrome, as usual ;) is a good way to go..
    should use the same heuristics as the taskbar?


- Marco Martin


On March 22, 2016, 8:15 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127467/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 8:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Move logic to C++ to be able to use fallback icon.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt b3e1855 
>   src/client.h 3b9050e 
>   src/client.cpp 6fc5814 
>   src/qml/ClientIcon.qml 83545a1 
> 
> Diff: https://git.reviewboard.kde.org/r/127467/diff/
> 
> 
> Testing
> -------
> 
> unknown icon is now displayed for streams without icon
> It would now also be possible to do some heuristic with matching binary name to desktop file as the FIXME suggests.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160323/394ed8c6/attachment-0001.html>