Review Request 127467: KCM: Fix showing empty stream icon
David Rosca
nowrep at gmail.com
Tue Mar 22 20:15:38 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127467/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-pa
Description
-------
Move logic to C++ to be able to use fallback icon.
Diffs
-----
src/CMakeLists.txt b3e1855
src/client.h 3b9050e
src/client.cpp 6fc5814
src/qml/ClientIcon.qml 83545a1
Diff: https://git.reviewboard.kde.org/r/127467/diff/
Testing
-------
unknown icon is now displayed for streams without icon
It would now also be possible to do some heuristic with matching binary name to desktop file as the FIXME suggests.
Thanks,
David Rosca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160322/ad590af9/attachment.html>
More information about the Plasma-devel
mailing list