Review Request 127467: PulseClient: Implement heuristics to find icon for stream

[David Rosca]

> On March 23, 2016, 10:47 a.m., Marco Martin wrote:
> > src/client.cpp, line 62
> > <https://git.reviewboard.kde.org/r/127467/diff/1/?file=453783#file453783line62>
> >
> >     I'm not sure having hardcoded special cases in c++ for broken applications (hello chrome, as usual ;) is a good way to go..
> >     should use the same heuristics as the taskbar?

I now added special case for plasmashell and kded, as those have no desktop file. Even though it's still hacky, I think it's better than to not show icon at all for these apps...


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127467/#review93884
-----------------------------------------------------------


On March 24, 2016, 8:17 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127467/
> -----------------------------------------------------------
> 
> (Updated March 24, 2016, 8:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Implement heuristics searching for icon in desktop files.
> Also try stream name to find icon if everything else fails.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3a0f690 
>   src/CMakeLists.txt b3e1855 
>   src/client.h 3b9050e 
>   src/client.cpp 6fc5814 
>   src/qml/ClientIcon.qml 83545a1 
> 
> Diff: https://git.reviewboard.kde.org/r/127467/diff/
> 
> 
> Testing
> -------
> 
> Streams now have icons even when icon_name or binary properites are empty.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160324/b6c8af3f/attachment.html>