[Differential] [Requested Changes To] D1066: Fix saving correct length of panel

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision now requires changes to proceed.


  this is a binding loop.
  
  PanelView.cpp has
  
    setResizeMode(QuickViewSharedEngine::SizeRootObjectToView);
  
  so we resize the window to the root object, then resize the root object to the view. At which point it doesn't really show anything.
  
  Can you talk me through the problem?
  
  I think /maybe/ the other fix is we change geometryByDistance to use width() and height(), which seems to match better given we're already using size() in that function.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1066

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, davidedmundson
Cc: davidedmundson, apol, plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160303/2604e8f4/attachment.html>