[Differential] [Commented On] D1066: Fix saving correct length of panel

[drosca (David Rosca)]

drosca added a comment.


  The problem is that PanelView::length() is always set to Layout.preferredSize, which says nothing about the actual panel length. PanelView::length() seems to be used only for restoring size of panel, but in most (all?) cases it gets overridden by minimumLength/maximumLength, so the panels are restored to correct size. Another use is in geometryByDistance, which can use size(), but it won't fix the main issue.
  
  I don't think there is a binding loop, because it doesn't actually resize the panel, it just saves the value to config and rest of PanelView::setLength is no-op.
  
  That being said, this timer is being fired too often, probably on height/width changed would be enough (but that needs more testing, because of the userConfiguring conditional).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1066

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, davidedmundson
Cc: davidedmundson, apol, plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160304/3d066b00/attachment.html>