<div>davidedmundson requested changes to this revision.<br />
davidedmundson added a reviewer: davidedmundson.<br />
davidedmundson added a comment.<br />
This revision now requires changes to proceed.</div><br /><div><div><p>this is a binding loop.</p>

<p>PanelView.cpp has</p>

<div class="remarkup-code-block" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="border: 1px solid #f1c40f;
          background: #fdf5d4;
          font-size: 10x;
          padding: 8px;">setResizeMode(QuickViewSharedEngine::SizeRootObjectToView);</pre></div>

<p>so we resize the window to the root object, then resize the root object to the view. At which point it doesn't really show anything.</p>

<p>Can you talk me through the problem?</p>

<p>I think /maybe/ the other fix is we change geometryByDistance to use width() and height(), which seems to match better given we're already using size() in that function.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1066" rel="noreferrer">https://phabricator.kde.org/D1066</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>drosca, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, apol, plasma-devel<br /></div>