[Differential] [Accepted] D1670: New login screen

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Sat Jun 4 19:27:01 UTC 2016


broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.


  Just fix those minor nitpicks and then good to go, thanks!

INLINE COMMENTS

> screenModel.qml:14
>  
>      //We create two monitors here, the left one 800x600 and the right one 800x400 pixels
>      //To disable a screen delete one of the "append" function calls

Please update that comment to reflect the changes below

> screenModel.qml:24
>              name: "Screen 2",
> -            geometry: {x: 800, y: 0, width: 800, height: 400},
> +            geometry: {x: 1980, y: 0, width: 1600, height: 900},
>          });

x: 1920 ?

> screenModel.qml:30
>          //return the primary monitor size
>          return Qt.rect(800, 0, 800, 400);
>      }

Primary is now 1600x900

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  login

REVISION DETAIL
  https://phabricator.kde.org/D1670

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: andreask, mart, broulik, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160604/263a1610/attachment.html>


More information about the Plasma-devel mailing list