<table><tr><td style="">broulik accepted this revision.<br />broulik added a reviewer: broulik.<br />broulik added a comment.<br />This revision is now accepted and ready to land.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1670" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Just fix those minor nitpicks and then good to go, thanks!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1670#inline-6908" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screenModel.qml:14</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">//We create two monitors here, the left one 800x600 and the right one 800x400 pixels</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">//To disable a screen delete one of the "append" function calls</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please update that comment to reflect the changes below</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1670#inline-6907" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screenModel.qml:24</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">name:</span> <span style="color: #766510">"Screen 2"</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #aa4000">geometry:</span> <span class="p">{</span><span style="color: #aa4000">x:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">800</span></span><span class="p">,</span> <span style="color: #aa4000">y:</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #aa4000">width:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">8</span>00</span><span class="p">,</span> <span style="color: #aa4000">height:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">4</span>00</span><span class="p">},</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">geometry:</span> <span class="p">{</span><span style="color: #aa4000">x:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">1980</span></span><span class="p">,</span> <span style="color: #aa4000">y:</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #aa4000">width:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">16</span>00</span><span class="p">,</span> <span style="color: #aa4000">height:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">9</span>00</span><span class="p">},</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">x: 1920 ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1670#inline-6909" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screenModel.qml:30</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">//return the primary monitor size</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">rect</span><span class="p">(</span><span style="color: #601200">800</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">800</span><span class="p">,</span> <span style="color: #601200">400</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Primary is now 1600x900</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>login</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1670" rel="noreferrer">https://phabricator.kde.org/D1670</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma, broulik<br /><strong>Cc: </strong>andreask, mart, broulik, plasma-devel, sebas<br /></div>