[Differential] [Commented On] D2295: improve logging for kscreen

[sebas (Sebastian Kügler)]

sebas added inline comments.

INLINE COMMENTS

> davidedmundson wrote in log.cpp:46
> It doesn't matter if there are threads *in* kscreen.
> 
> The question is: Can a kscreen class be used *in* another thread by $app.

That's what I meant, it's not designed to be thread-safe at all. The backends have static members, too, so this pattern isn't exclusive to this class at all.

> davidedmundson wrote in log.cpp:137
> Edit:  Some googling suggests this is fine as-is.
> 
> O_APPEND writes are atomic on local filesystems, and will lock between updating the offset and the end of the write.
> 
> Providing Qt does everything as one write() which it probably will for lines less than ~512bytes or so.

Cool. Thanks for checking this.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/log

REVISION DETAIL
  https://phabricator.kde.org/D2295

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, bshah
Cc: davidedmundson, bshah, plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160728/59e7edd8/attachment.html>