[Differential] [Commented On] D2295: improve logging for kscreen

[sebas (Sebastian Kügler)]

sebas added inline comments.

INLINE COMMENTS

> davidedmundson wrote in log.cpp:30
> why have it separate instead of a member of log?

I just tried making it a member, but running into problems.

QtMessageHandler is a typedef'ed function pointer,  not a class. If I add a static member in my Log class for it, it screws up my header.

I think we need to keep this as is (which arguably is nicer, anyway, since it keeps QtMessageHandler outside of the header, and thus the API.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/log

REVISION DETAIL
  https://phabricator.kde.org/D2295

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, bshah
Cc: davidedmundson, bshah, plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160728/fc4df9ee/attachment-0001.html>