[Differential] [Commented On] D2295: improve logging for kscreen

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in log.cpp:137
> It's one QLockFile line...

Edit:  Some googling suggests this is fine as-is.

O_APPEND writes are atomic on local filesystems, and will lock between updating the offset and the end of the write.

Providing Qt does everything as one write() which it probably will for lines less than ~512bytes or so.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/log

REVISION DETAIL
  https://phabricator.kde.org/D2295

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, bshah
Cc: davidedmundson, bshah, plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160728/604649ab/attachment.html>