[Differential] [Commented On] D2295: improve logging for kscreen

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> sebas wrote in log.cpp:46
> No threads in libkscreen. It'll probably blow up in many other cases already.

It doesn't matter if there are threads *in* kscreen.

The question is: Can a kscreen class be used *in* another thread by $app.

> sebas wrote in log.cpp:137
> It's actually complexity I want to avoid. If the logs are messed up, bad luck, but introducing wait locks and the likes brings in so much complexity, I think it's better to avoid here  until it becomes a problem.

It's one QLockFile line...

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/log

REVISION DETAIL
  https://phabricator.kde.org/D2295

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, bshah
Cc: davidedmundson, bshah, plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160728/ea500d91/attachment.html>