Review Request 128484: Don't set a Window Icon on Plamsa::Dialog
Martin Gräßlin
mgraesslin at kde.org
Tue Jul 19 05:44:08 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128484/#review97586
-----------------------------------------------------------
In KWin it can be seen when e.g. activating Present Windows while Kickoff is open or the calendar. Also in Alt+Tab this could happen.
KWin will show an icon - always - in the worst case it will be the generic X icon. If we go for that we must make sure that Plasma window are excluded from all KWin elements.
- Martin Gräßlin
On July 19, 2016, 6:26 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128484/
> -----------------------------------------------------------
>
> (Updated July 19, 2016, 6:26 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> It's practically never visible.
>
> Window flags are always masked with FramelessWindowHint and we always
> have the state NET::SkipTaskbar | NET::SkipPager set.
>
> (There is theoretically a code path that would allow an icon to be
> visible in some kwin effects that overlay icons..but not triggerable by
> anything in Plasma, at which point why would you want a Plasma icon
> anyway)
>
> This saves a bit of memory (up to 512K) as window icons are always
> loaded at every size to set the _NET_WM_ICON.
>
>
> Diffs
> -----
>
> src/plasmaquick/dialog.cpp be7406725ff0876f7ebee63c752e6ea84f90e577
>
> Diff: https://git.reviewboard.kde.org/r/128484/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160719/3a93c1ef/attachment.html>
More information about the Plasma-devel
mailing list