Review Request 128484: Don't set a Window Icon on Plamsa::Dialog
David Edmundson
david at davidedmundson.co.uk
Tue Jul 19 04:26:22 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128484/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-framework
Description
-------
It's practically never visible.
Window flags are always masked with FramelessWindowHint and we always
have the state NET::SkipTaskbar | NET::SkipPager set.
(There is theoretically a code path that would allow an icon to be
visible in some kwin effects that overlay icons..but not triggerable by
anything in Plasma, at which point why would you want a Plasma icon
anyway)
This saves a bit of memory (up to 512K) as window icons are always
loaded at every size to set the _NET_WM_ICON.
Diffs
-----
src/plasmaquick/dialog.cpp be7406725ff0876f7ebee63c752e6ea84f90e577
Diff: https://git.reviewboard.kde.org/r/128484/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160719/9147d703/attachment.html>
More information about the Plasma-devel
mailing list