Review Request 128484: Don't set a Window Icon on Plamsa::Dialog

[Kai Uwe Broulik]

> On Juli 19, 2016, 5:44 vorm., Martin Gräßlin wrote:
> > In KWin it can be seen when e.g. activating Present Windows while Kickoff is open or the calendar. Also in Alt+Tab this could happen.
> > 
> > KWin will show an icon - always - in the worst case it will be the generic X icon. If we go for that we must make sure that Plasma window are excluded from all KWin elements.

I thought that was the idea but we set skip pager and skip taskbar but that doesn't imply skip $other-effects (which is to be expected, I suppose) so we have the situation we're in now.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128484/#review97586
-----------------------------------------------------------


On Juli 19, 2016, 4:26 vorm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128484/
> -----------------------------------------------------------
> 
> (Updated Juli 19, 2016, 4:26 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> It's practically never visible.
> 
> Window flags are always masked with FramelessWindowHint and we always
> have the state NET::SkipTaskbar | NET::SkipPager set.
> 
> (There is theoretically a code path that would allow an icon to be
> visible in some kwin effects that overlay icons..but not triggerable by
> anything in Plasma, at which point why would you want a Plasma icon
> anyway)
> 
> This saves a bit of memory (up to 512K) as window icons are always
> loaded at every size to set the _NET_WM_ICON.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp be7406725ff0876f7ebee63c752e6ea84f90e577 
> 
> Diff: https://git.reviewboard.kde.org/r/128484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160719/5eb6e6f0/attachment-0001.html>