Review Request 128402: Kickoff: Add option to hide Favorites tab

[John Salatas]

> On July 8, 2016, 9:35 a.m., Kai Uwe Broulik wrote:
> > -1
> > 
> > What I would instead like is the ability to re-arrange and hide individual tabs, see Bug 361210, but not a corner-case solution for just the favorites.
> 
> John Salatas wrote:
>     Yes! That would be great! Not sure if I can implement it through drag and drop, but I could give it a try :\
> 
> Kai Uwe Broulik wrote:
>     As a first step already having the infrastructure in the applet, ie. a stringlist setting <default>favorites,applications,history,...</default> and the applet placing the tabs as configured would be nice.
>     
>     A fancy settings UI with drag and drop could be added at a later stage.
> 
> David Edmundson wrote:
>     Or should we just hide if a model is empty?
>     
>     We have an existing bug on the leave tab existing even if all the entries are disabled with kiosk.
> 
> Kai Uwe Broulik wrote:
>     I made a patch for that a while ago (eg. hide History tab when empty) but it was rejected for... "performance" reasons.

Patch updated as per Kai Uwe Broulik's suggestion. 

Not sure if I did it the correct way but I guess I didn't as it is actually my first qml application :\

I would appreciate your feedback!


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97199
-----------------------------------------------------------


On July 9, 2016, 6:48 p.m., John Salatas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 6:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 361210
>     https://bugs.kde.org/show_bug.cgi?id=361210
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab in kickoff is somewhat redundant, as I have added launchers for all of my favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide any menu and also according to bug 36210 to reorganize them.
> 
> In the attached screenshot you can see
> 
> 1) the configuration options: These are just the menu buttons than can be rearranged via drag n drop and the also include a checkbox (checked: show it, unchecked: hide it).
> 2) The Kickoff menu with just 3 menu items (the other two are hidden).
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/code/ButtonTools.js PRE-CREATION 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
>   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE Neon Developer Stable (as of July 8, 2016)
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
> 
> 
> Thanks,
> 
> John Salatas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160709/0db93ae5/attachment-0001.html>