<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128402/">https://git.reviewboard.kde.org/r/128402/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 8th, 2016, 9:35 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-1</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What I would instead like is the ability to re-arrange and hide individual tabs, see Bug 361210, but not a corner-case solution for just the favorites.</p></pre>
</blockquote>
<p>On July 8th, 2016, 9:47 a.m. UTC, <b>John Salatas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes! That would be great! Not sure if I can implement it through drag and drop, but I could give it a try :\</p></pre>
</blockquote>
<p>On July 8th, 2016, 9:53 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As a first step already having the infrastructure in the applet, ie. a stringlist setting <default>favorites,applications,history,...</default> and the applet placing the tabs as configured would be nice.
A fancy settings UI with drag and drop could be added at a later stage.</pre>
</blockquote>
<p>On July 8th, 2016, 10:11 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Or should we just hide if a model is empty?
We have an existing bug on the leave tab existing even if all the entries are disabled with kiosk.</pre>
</blockquote>
<p>On July 8th, 2016, 10:13 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I made a patch for that a while ago (eg. hide History tab when empty) but it was rejected for... "performance" reasons.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch updated as per Kai Uwe Broulik's suggestion. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not sure if I did it the correct way but I guess I didn't as it is actually my first qml application :\</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would appreciate your feedback!</p></pre>
<br />
<p>- John</p>
<br />
<p>On July 9th, 2016, 6:48 p.m. UTC, John Salatas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By John Salatas.</div>
<p style="color: grey;"><i>Updated July 9, 2016, 6:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=361210">361210</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab in kickoff is somewhat redundant, as I have added launchers for all of my favorites in the Icons-Only Task Manager.
So in this patch I'm introducing an option to hide any menu and also according to bug 36210 to reorganize them.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In the attached screenshot you can see</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) the configuration options: These are just the menu buttons than can be rearranged via drag n drop and the also include a checkbox (checked: show it, unchecked: hide it).
2) The Kickoff menu with just 3 menu items (the other two are hidden).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested in KDE Neon Developer Stable (as of July 8, 2016)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/package/contents/code/ButtonTools.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kickoff/package/contents/config/main.xml <span style="color: grey">(2de73ba)</span></li>
<li>applets/kickoff/package/contents/ui/ConfigButtons.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/kickoff/package/contents/ui/ConfigGeneral.qml <span style="color: grey">(011b76b)</span></li>
<li>applets/kickoff/package/contents/ui/FullRepresentation.qml <span style="color: grey">(8ac029c)</span></li>
<li>applets/kickoff/package/contents/ui/KickoffButton.qml <span style="color: grey">(6b3a2b7)</span></li>
<li>applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128402/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>