Review Request 128402: Kickoff: Add option to hide Favorites tab

[Kai Uwe Broulik]

> On Juli 8, 2016, 9:35 vorm., Kai Uwe Broulik wrote:
> > -1
> > 
> > What I would instead like is the ability to re-arrange and hide individual tabs, see Bug 361210, but not a corner-case solution for just the favorites.
> 
> John Salatas wrote:
>     Yes! That would be great! Not sure if I can implement it through drag and drop, but I could give it a try :\
> 
> Kai Uwe Broulik wrote:
>     As a first step already having the infrastructure in the applet, ie. a stringlist setting <default>favorites,applications,history,...</default> and the applet placing the tabs as configured would be nice.
>     
>     A fancy settings UI with drag and drop could be added at a later stage.
> 
> David Edmundson wrote:
>     Or should we just hide if a model is empty?
>     
>     We have an existing bug on the leave tab existing even if all the entries are disabled with kiosk.

I made a patch for that a while ago (eg. hide History tab when empty) but it was rejected for... "performance" reasons.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97199
-----------------------------------------------------------


On Juli 8, 2016, 6:35 vorm., John Salatas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> -----------------------------------------------------------
> 
> (Updated Juli 8, 2016, 6:35 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab in kickoff is somewhat redundant, as I have added launchers for all of my favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide Favorites from the kickoff
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> -------
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160708/e6d409ce/attachment.html>