Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/
-----------------------------------------------------------

(Updated Jan. 15, 2016, 3:03 nachm.)


Review request for Plasma, Jan Grulich and Lamarque Souza.


Changes
-------

- Remember which connections were active before suspending and don't show a "notification activated" message for those
- If there is no active or activating connection 5s after resuming, show a message that you're no longer connected to a network

I connected to a Wifi, suspended (no disconnect notification), resumed (no connect notification)
I enabled a hotspot on my phone and connected to it, suspended (no disconnect notification), turned the hotspot off, resumed, it connected to my regular Wifi and showed a notification that I'm now connected to this one instead

I couldn't test the "you are not connected" notification as when I remove my regular Wifi connection it tries to activate the hotspot (ie. there's an activating connection) I disabled in the meantime and is stuck at "configuring interface" until it times out. We could only look for active connections but that might take longer than 5 seconds?


Repository: plasma-nm


Description
-------

It's quite natural that the connection goes away when we're about to suspend :) Watch for this and then don't emit the notification.


Diffs (updated)
-----

  kded/networkmanagement.notifyrc 7ce437c 
  kded/notification.h 9b8b51a 
  kded/notification.cpp 231d69e 

Diff: https://git.reviewboard.kde.org/r/126748/diff/


Testing
-------

While I still think Plasma-NM is waaaaaay too verbose about everything, at least it doesn't tell me that I just disconnected when I suspend.

I still get the notification when I turn off Wifi manually.
I also still get the notification that I'm connected again shortly after resuming.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160115/4945c2c7/attachment.html>