<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126748/">https://git.reviewboard.kde.org/r/126748/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Jan Grulich and Lamarque Souza.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2016, 3:03 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Remember which connections were active before suspending and don't show a "notification activated" message for those
- If there is no active or activating connection 5s after resuming, show a message that you're no longer connected to a network
I connected to a Wifi, suspended (no disconnect notification), resumed (no connect notification)
I enabled a hotspot on my phone and connected to it, suspended (no disconnect notification), turned the hotspot off, resumed, it connected to my regular Wifi and showed a notification that I'm now connected to this one instead
I couldn't test the "you are not connected" notification as when I remove my regular Wifi connection it tries to activate the hotspot (ie. there's an activating connection) I disabled in the meantime and is stuck at "configuring interface" until it times out. We could only look for active connections but that might take longer than 5 seconds?</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's quite natural that the connection goes away when we're about to suspend :) Watch for this and then don't emit the notification.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While I still think Plasma-NM is waaaaaay too verbose about everything, at least it doesn't tell me that I just disconnected when I suspend.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I still get the notification when I turn off Wifi manually.
I also still get the notification that I'm connected again shortly after resuming.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kded/networkmanagement.notifyrc <span style="color: grey">(7ce437c)</span></li>
<li>kded/notification.h <span style="color: grey">(9b8b51a)</span></li>
<li>kded/notification.cpp <span style="color: grey">(231d69e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126748/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>