Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

[Jan Grulich]

> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* reconnected (to any network) on resume?
> 
> Kai Uwe Broulik wrote:
>     Doesn't it tell you that anyway? At least when I try to connect to something and it fails I get like 3 notifications about different failures.
> 
> Martin Klapetek wrote:
>     What I mean is when you suspend your laptop at home, connected to your home network, you go out and resume your laptop say at your friend where you didn't connect to the wifi before, so it's unknown and your laptop will not connect to anything and will not even try. At that point, it should show a "disconnected" notification, maybe?
> 
> Kai Uwe Broulik wrote:
>     Ah, I see. How should I do that? If it disconnected on suspend and didn't attempt to reconnect within 5 seconds show a notification that you're no longer connected?
> 
> Jan Grulich wrote:
>     The patch looks good and makes sense. Do I get it right that once you resume your computer then PrepareForSleep signal is emitted with false value to re-enable showing notifications? What Martin suggests is also a good idea, maybe not showing a notification that you got disconnected, but just make you aware you are no longer connected. What would be also useful to store all connections which got disconnected before suspend and on resume do not show notification about their activation if they were active before suspend, just with an exception if you activate them manually (which will be case mostly for VPN connections).
> 
> Kai Uwe Broulik wrote:
>     Yes, prepareForSleep is emitted again on resume with the parameter being false.
>     
>     So, I'll store the connections that were active at the time of suspend in a vector, when I resume:
>     - I don't show a connect notification about a connection that was active prior to suspend
>     - I show a notification "You are no longer connected" when after like 5 seconds up no connection is active or connecting
> 
> Kai Uwe Broulik wrote:
>     When I store the notification it is for example /activeconnection/2 but on resume I have /activeconnection/3, how can I map the new connection to the old one? Or do I need to do that manually, like look at Access Point and stuff like that, but how would that scale with all the other types we have?
> 
> Jan Grulich wrote:
>     1) Be aware that not all connections can be auto-activated again (I can think of VPN connections) and those that are not auto-activated need manuall intervention. I would ignore those as it is sure that they were manually activated and thus users should be notified about succesful activation. 
>     2) Sounds good
>     
>     + please add Lamarque to the review, maybe he can think of another possible use case

Each active connection should have UUID of "connection/connection setting" it represents, which is still the same.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
-----------------------------------------------------------


On Led. 14, 2016, 6:19 odp., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> -----------------------------------------------------------
> 
> (Updated Led. 14, 2016, 6:19 odp.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> It's quite natural that the connection goes away when we're about to suspend :) Watch for this and then don't emit the notification.
> 
> 
> Diffs
> -----
> 
>   kded/notification.h 9b8b51a 
>   kded/notification.cpp 231d69e 
> 
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
> 
> 
> Testing
> -------
> 
> While I still think Plasma-NM is waaaaaay too verbose about everything, at least it doesn't tell me that I just disconnected when I suspend.
> 
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after resuming.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160115/39e0a558/attachment.html>