Review Request 127133: DataContainer: Fix slot checks before connect/disconnect

David Rosca nowrep at gmail.com
Tue Feb 23 18:12:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127133/
-----------------------------------------------------------

(Updated Feb. 23, 2016, 8:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 172847fc3b6b94fc9f7bfd1e107248c8e3939a9a by David Rosca to branch master.


Repository: plasma-framework


Description
-------

Use indexOfSlot instead of indexOfMethod and check for index >= 0.
Also added missing checks for all dataUpdated connects.


Diffs
-----

  src/plasma/datacontainer.cpp 396bc6d 

Diff: https://git.reviewboard.kde.org/r/127133/diff/


Testing
-------

Fixes warnings when removing show activity manager applet.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160223/4d99034f/attachment-0001.html>


More information about the Plasma-devel mailing list