Review Request 127133: DataContainer: Fix slot checks before connect/disconnect

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127133/#review92612
-----------------------------------------------------------


Ship it!




you're awesome.

- David Edmundson


On Feb. 21, 2016, 1:43 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127133/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2016, 1:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Use indexOfSlot instead of indexOfMethod and check for index >= 0.
> Also added missing checks for all dataUpdated connects.
> 
> 
> Diffs
> -----
> 
>   src/plasma/datacontainer.cpp 396bc6d 
> 
> Diff: https://git.reviewboard.kde.org/r/127133/diff/
> 
> 
> Testing
> -------
> 
> Fixes warnings when removing show activity manager applet.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160221/217bd808/attachment.html>