Review Request 127118: ToolTip: Prevent multiple geometry changes while changing contents

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127118/#review92597
-----------------------------------------------------------



looks good. Especially the re-ordering. Changing setMainItem to be before show() I think is going to be the killer change. 

One comment, (which I think isn't your code, but you might know now you're the ToolTip dialog expert :D )


src/declarativeimports/core/tooltip.cpp (line 135)
<https://git.reviewboard.kde.org/r/127118/#comment63122>

    This took me a long time to understand. 
    
    Can I reword this comment to.
    //Unset the dialog's old contents before reparenting the dialog.



src/declarativeimports/core/tooltip.cpp (line 138)
<https://git.reviewboard.kde.org/r/127118/#comment63123>

    I don't get this bit.
    
    We're setting the new contents to invisible just before we show it.
    
    It would make sense if it was:
    dlg->mainItem()->setVisible(false)
    
    to say "we're about to replace the main item, set the old one to invisible to save updates now that it's not shown."
    
    but this doesn't seem to.


- David Edmundson


On Feb. 20, 2016, 4:58 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127118/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, 4:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Unset mainItem and set it back only after changing of tooltip contents is completed.
> This improves behavior of morphingpopups effect (popups animates from/to incorrect values), but there is still bug in (I think) KWin https://bugs.kde.org/show_bug.cgi?id=359604
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltip.cpp 3d2e7da 
> 
> Diff: https://git.reviewboard.kde.org/r/127118/diff/
> 
> 
> Testing
> -------
> 
> Tested with morphing popups effect, only one geometry change event is sent when tooltip slides to new position.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160221/39d8828d/attachment.html>