Review Request 127118: ToolTip: Prevent multiple geometry changes while changing contents

David Rosca nowrep at gmail.com
Sat Feb 20 16:58:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127118/
-----------------------------------------------------------

(Updated Feb. 20, 2016, 4:58 p.m.)


Review request for Plasma.


Summary (updated)
-----------------

ToolTip: Prevent multiple geometry changes while changing contents


Repository: plasma-framework


Description (updated)
-------

Unset mainItem and set it back only after changing of tooltip contents is completed.
This improves behavior of morphingpopups effect (popups animates from/to incorrect values), but there is still bug in (I think) KWin https://bugs.kde.org/show_bug.cgi?id=359604


Diffs (updated)
-----

  src/declarativeimports/core/tooltip.cpp 3d2e7da 

Diff: https://git.reviewboard.kde.org/r/127118/diff/


Testing
-------

Tested with morphing popups effect, only one geometry change event is sent when tooltip slides to new position.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160220/044a6a83/attachment.html>


More information about the Plasma-devel mailing list