Review Request 127118: ToolTip: Prevent multiple geometry changes while changing contents

[David Rosca]

> On Feb. 21, 2016, 12:33 a.m., David Edmundson wrote:
> > src/declarativeimports/core/tooltip.cpp, line 138
> > <https://git.reviewboard.kde.org/r/127118/diff/2/?file=444745#file444745line138>
> >
> >     I don't get this bit.
> >     
> >     We're setting the new contents to invisible just before we show it.
> >     
> >     It would make sense if it was:
> >     dlg->mainItem()->setVisible(false)
> >     
> >     to say "we're about to replace the main item, set the old one to invisible to save updates now that it's not shown."
> >     
> >     but this doesn't seem to.

When Dialog changes mainItem, it calls setVisible(false) on the old one. So dlg->mainItem()->setVisible(false) is done one line above (setMainItem(0)).

mainItem()->setVisible(false) here is probably not needed, I'll remove it.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127118/#review92597
-----------------------------------------------------------


On Feb. 20, 2016, 4:58 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127118/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2016, 4:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Unset mainItem and set it back only after changing of tooltip contents is completed.
> This improves behavior of morphingpopups effect (popups animates from/to incorrect values), but there is still bug in (I think) KWin https://bugs.kde.org/show_bug.cgi?id=359604
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltip.cpp 3d2e7da 
> 
> Diff: https://git.reviewboard.kde.org/r/127118/diff/
> 
> 
> Testing
> -------
> 
> Tested with morphing popups effect, only one geometry change event is sent when tooltip slides to new position.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160221/887a9491/attachment-0001.html>