[Differential] [Commented On] D986: Revamp of the activity switcher backend

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS
  imports/activitymanager/backport/model_updaters.h:2 year.
  imports/activitymanager/backport/switcheractivitiesmodel.cpp:280 just use shownActivities.contains() it's a normal QVector after all
  imports/activitymanager/backport/switcheractivitiesmodel.cpp:322 why not state too?
  imports/activitymanager/backport/switcheractivitiesmodel.cpp:363 This is would fail modelTest.
  
  to ensure it's a flat model you need
  
  if parent.isValid() 
   return 0;
  
  even for an AbstractList
  imports/activitymanager/backport/switcheractivitiesmodel.cpp:371 just write .at(row)
  
  imports/activitymanager/sortedactivitiesmodel.cpp:238 this won't work.
  
  there is no dataChanged() emitted from the source model when the lastUsedTime changes - so it won't resort

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D986

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, davidedmundson, sebas, mart
Cc: plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160218/ef869e1f/attachment.html>