<div>davidedmundson added inline comments.</div><br /><div><strong>INLINE COMMENTS</strong><div><div>imports/activitymanager/backport/model_updaters.h:2 year.</div><div>imports/activitymanager/backport/switcheractivitiesmodel.cpp:280 just use shownActivities.contains() it's a normal QVector after all</div><div>imports/activitymanager/backport/switcheractivitiesmodel.cpp:322 why not state too?</div><div>imports/activitymanager/backport/switcheractivitiesmodel.cpp:363 This is would fail modelTest.<br />
<br />
to ensure it's a flat model you need<br />
<br />
if parent.isValid() <br />
 return 0;<br />
<br />
even for an AbstractList</div><div>imports/activitymanager/backport/switcheractivitiesmodel.cpp:371 just write .at(row)<br />
</div><div>imports/activitymanager/sortedactivitiesmodel.cpp:238 this won't work.<br />
<br />
there is no dataChanged() emitted from the source model when the lastUsedTime changes - so it won't resort</div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D986" rel="noreferrer">https://phabricator.kde.org/D986</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>ivan, davidedmundson, sebas, mart<br /><strong>Cc: </strong>plasma-devel<br /></div>