Review Request 127073: AppletQuickItem: Fix finding own attached layout
David Edmundson
david at davidedmundson.co.uk
Mon Feb 15 16:29:14 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92406
-----------------------------------------------------------
src/plasmaquick/appletquickitem.cpp (line 736)
<https://git.reviewboard.kde.org/r/127073/#comment63025>
if that's the case, filter on event->child()->metaObject.className()
rather than creating a new event for every single child
- David Edmundson
On Feb. 13, 2016, 11:48 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2016, 11:48 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 358849
> http://bugs.kde.org/show_bug.cgi?id=358849
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Regression from 344dbeb938
>
> BUG: 358849
>
>
> Diffs
> -----
>
> src/plasmaquick/appletquickitem.h 1e0174a
> src/plasmaquick/appletquickitem.cpp 28f1eb5
> src/plasmaquick/private/appletquickitem_p.h 1f99d2f
>
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
>
>
> Testing
> -------
>
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, though.
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160215/f092fac1/attachment.html>
More information about the Plasma-devel
mailing list