Review Request 127073: AppletQuickItem: Fix finding own attached layout

[Anthony Fieroni]

> On Фев. 15, 2016, 12:06 след обяд, Marco Martin wrote:
> > src/plasmaquick/appletquickitem.cpp, line 55
> > <https://git.reviewboard.kde.org/r/127073/diff/2/?file=444222#file444222line55>
> >
> >     why splitting it in a separate method if you don't call it from anywhere else?
> 
> David Rosca wrote:
>     Because d-pointer is accessed from `childEvent` which is called from AppletQuickItemPrivate constructor (`qmlObject` parented to `q`), and at that point `d` is dangling pointer.

David Rosca +1, this is why, when you see *this* in contructor initialization list aways can be dangerous :)


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92387
-----------------------------------------------------------


On Фев. 14, 2016, 1:48 преди обяд, David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> -----------------------------------------------------------
> 
> (Updated Фев. 14, 2016, 1:48 преди обяд)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 358849
>     http://bugs.kde.org/show_bug.cgi?id=358849
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Regression from 344dbeb938
> 
> BUG: 358849
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/appletquickitem.h 1e0174a 
>   src/plasmaquick/appletquickitem.cpp 28f1eb5 
>   src/plasmaquick/private/appletquickitem_p.h 1f99d2f 
> 
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
> 
> 
> Testing
> -------
> 
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160215/a581d636/attachment-0001.html>