Review Request 127073: AppletQuickItem: Fix finding own attached layout

[David Rosca]

> On Feb. 15, 2016, 4:29 p.m., David Edmundson wrote:
> > src/plasmaquick/appletquickitem.cpp, line 736
> > <https://git.reviewboard.kde.org/r/127073/diff/2/?file=444222#file444222line736>
> >
> >     if that's the case, filter on event->child()->metaObject.className()
> >     
> >     rather than creating a new event for every single child

Unfortunately that doesn't work, it just shows as QObject.

>From doc:
>QEvent::ChildAdded and QEvent::ChildRemoved events are sent to objects when children are added or removed. In both cases you can only rely on the child being a QObject, or if isWidgetType() returns true, a QWidget. (This is because, in the ChildAdded case, the child is not yet fully constructed, and in the ChildRemoved case it might have been destructed already).


If the applet has attached Layout, it is generally the first and only child that will get through the conditionals and actually creates the timer.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92406
-----------------------------------------------------------


On Feb. 13, 2016, 11:48 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 11:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 358849
>     http://bugs.kde.org/show_bug.cgi?id=358849
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Regression from 344dbeb938
> 
> BUG: 358849
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/appletquickitem.h 1e0174a 
>   src/plasmaquick/appletquickitem.cpp 28f1eb5 
>   src/plasmaquick/private/appletquickitem_p.h 1f99d2f 
> 
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
> 
> 
> Testing
> -------
> 
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160215/4b7864e9/attachment.html>