Review Request 126946: ShowDesktop is not synchronized

Anthony Fieroni bvbfan at
Sat Feb 6 14:57:50 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Фев. 6, 2016, 4:57 след обяд)

Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin.


I try to remove netwm and X11 specific code, but i'm stuck on moving window by WId. I read that on Wayland is not available (on Martin's bog :)).

Repository: kdeplasma-addons


Activity pager settings -> Selecting current desktop -> showDesktop. If desktop is showed by clicking on widget, it can be restored by clicking on item in task manager, which lead m_desktopDown to store incorrect state.

Diffs (updated)

  applets/activitypager/plugin/activitypager.h d33e81e 
  applets/activitypager/plugin/activitypager.cpp b991bac 



Now works correctly, but i'm affraid about checks
#if HAVE_X11
    if (!m_isX11) {
why the is performed and even why the hell NETRootInfo is used in that way. And NETRootInfo::showingDesktop() about be is hell not working function.


Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Plasma-devel mailing list