Review Request 126946: ShowDesktop is not synchronized

[Martin Gräßlin]

> On Feb. 2, 2016, 1:54 a.m., Sebastian Kügler wrote:
> > Ship It!
> 
> Sebastian Kügler wrote:
>     For bonus points, you could check if there's any X11 usage in the applet otherwise, and if not, remove the m_isX11 and HAVE_X11 conditionals. This is nicely abstracted in KWindowSystem now, the code there is a bit dated in that regard.
> 
> Anthony Fieroni wrote:
>     It's not so nice, NETRootInfo::desktopLayoutColumnsRows to KWindowSystem?

might be all dead code if it's just for desktops.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126946/#review91909
-----------------------------------------------------------


On Feb. 1, 2016, 7:24 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126946/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 7:24 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Activity pager settings -> Selecting current desktop -> showDesktop. If desktop is showed by clicking on widget, it can be restored by clicking on item in task manager, which lead m_desktopDown to store incorrect state.
> 
> 
> Diffs
> -----
> 
>   applets/activitypager/plugin/activitypager.cpp b991bac 
> 
> Diff: https://git.reviewboard.kde.org/r/126946/diff/
> 
> 
> Testing
> -------
> 
> Now works correctly, but i'm affraid about checks
> #if HAVE_X11
>     if (!m_isX11) {
>         return;
>     }
> why the is performed and even why the hell NETRootInfo is used in that way. And NETRootInfo::showingDesktop() about be is hell not working function.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160202/a197409e/attachment.html>