Review Request 126946: Remove specific X11 code

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126946/#review92140
-----------------------------------------------------------




applets/activitypager/plugin/activitypager.cpp (line 376)
<https://git.reviewboard.kde.org/r/126946/#comment62857>

    please use lowercase variable names.



applets/activitypager/plugin/activitypager.cpp (line 482)
<https://git.reviewboard.kde.org/r/126946/#comment62858>

    note: this will only work on X11, but not on Wayland.



applets/activitypager/plugin/activitypager.cpp (line 486)
<https://git.reviewboard.kde.org/r/126946/#comment62859>

    please do not move foreign windows through setting the geometry. Window Manager won't like it. That's what the NET variant used.
    
    In this case I think it would be fine to still have platform specific code as it's X11 specific anyway. The longer term solution will be to add API to KWindowSystem to move foreign windows.


- Martin Gräßlin


On Feb. 6, 2016, 3:57 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126946/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2016, 3:57 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Activity pager settings -> Selecting current desktop -> showDesktop. If desktop is showed by clicking on widget, it can be restored by clicking on item in task manager, which lead m_desktopDown to store incorrect state.
> 
> 
> Diffs
> -----
> 
>   applets/activitypager/plugin/activitypager.h d33e81e 
>   applets/activitypager/plugin/activitypager.cpp b991bac 
> 
> Diff: https://git.reviewboard.kde.org/r/126946/diff/
> 
> 
> Testing
> -------
> 
> I'm not pretty sure QWindow::fromWinId works on Wayland and must be correcly implement
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160208/a2fae872/attachment-0001.html>