[Differential] [Requested Changes To] D3758: [AppletInterface] Emit toolTipMainTextChanged if it changes in response to a title change

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Not your fault, but this current code is completely wrong and needs fixing.
  
  It should *not* be emitting a signal in setTitle.
  
  AppletInterface::setTitle calls Applet::setTitle -- which in turn emits Applet::titleChanged 
  Applet::titleChanged is already connected to AppletInterface::titleChanged
  
  Tooltip is a bit more complex because there's some logic here, but in any case it needs to be following changes to Applet::title not AppletInterface::title

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3758

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161220/8eb4d621/attachment.html>