<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added a reviewer: davidedmundson.<br />davidedmundson added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3758" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Not your fault, but this current code is completely wrong and needs fixing.</p>
<p>It should *not* be emitting a signal in setTitle.</p>
<p>AppletInterface::setTitle calls Applet::setTitle -- which in turn emits Applet::titleChanged <br />
Applet::titleChanged is already connected to AppletInterface::titleChanged</p>
<p>Tooltip is a bit more complex because there's some logic here, but in any case it needs to be following changes to Applet::title not AppletInterface::title</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Frameworks</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3758" rel="noreferrer">https://phabricator.kde.org/D3758</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>