[Differential] [Accepted] D3687: take matching logic out of match method and put it into a class

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks

INLINE COMMENTS

> servicerunner.cpp:124
> +            qCDebug(RUNNER_SERVICES) << service->name() << "is an exact match!" << service->storageId() << service->exec();
> +            if (service->noDisplay() || service->property(QStringLiteral("NotShowIn"), QVariant::String) == "KDE") {
>                  continue;

isnt NotShowIn a list property? Doesn't KService have a getter for that or even take that into account in noDisplay()?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161215/30e062f9/attachment.html>