[Differential] [Request, 412 lines] D3687: take matching logic out of match method and put it into a class

[sitter (Harald Sitter)]

sitter created this revision.
sitter added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  refactor and qcdebug
  
  ::match was a super long spagetthi with multiple sub-matches. 
  This was supposedly primarily because it needed to be stateful across all sub-matches. To deal with this there's a new class which is taking care of the stateful service finding, this class is comprised of multiple matching functions that contribute to the full match set.
  Good enough readability for now. Classes for this would be nicer though.
  
  Also add qcdebug for this runner so we can get a better idea of why results are the way they are. Defaults to warning so it's silent by default.

TEST PLAN
  Careful refactoring so hopefully no problems.
  
  - still matches binary names as best match
  - still matches comments
  - still matches generic names
  - still matches names

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3687

AFFECTED FILES
  runners/services/CMakeLists.txt
  runners/services/servicerunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161215/8ed59820/attachment.html>