[Differential] [Commented On] D3687: take matching logic out of match method and put it into a class

[sitter (Harald Sitter)]

sitter added inline comments.

INLINE COMMENTS

> broulik wrote in servicerunner.cpp:124
> isnt NotShowIn a list property? Doesn't KService have a getter for that or even take that into account in noDisplay()?

something to consider in a follow up, for now I'd like to get the refactor landed.

e.g. `if (!service->isApplication()) {` further down also seems weird considering we already queried for applications specifically.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161215/a9abc0d7/attachment.html>