[Differential] [Updated, 589 lines] D2687: [Icon Widget] Bring back properties dialog

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Thu Dec 15 09:15:13 UTC 2016


broulik updated this revision to Diff 9029.
broulik marked 2 inline comments as done.
broulik added a comment.


  - update actions also in Component.onCompleted so the "configure" button in applet handle works correctly the first time
  - Set icon for properties dialog ("document-properties", same as the context menu) instead of generic Plasma icon
  - Let processDrop return void, nobody used the return value
  - Use QUrl::toStringList
  - Parent KRun to QApplication::desktop()
  - Some minor cleanup

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2687?vs=8968&id=9029

REVISION DETAIL
  https://phabricator.kde.org/D2687

AFFECTED FILES
  applets/icon/CMakeLists.txt
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/config/main.xml
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161215/5d77539c/attachment-0001.html>


More information about the Plasma-devel mailing list