[Differential] [Updated] D2687: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik marked 4 inline comments as done.
broulik added inline comments.

INLINE COMMENTS

> dfaure wrote in iconapplet.cpp:242
> Just wondering, why is the parent widget nullptr here, while it's QApplication::desktop() in other code further down? Not that it changes anything at runtime, I suppose.

No particular reason, changed it to QApplication::desktop() now

> dfaure wrote in iconapplet.cpp:306
> This for loop can be written in one line with
> 
>   const QStringList params = QUrl::toStringList(urls);
> 
> (I added that to QUrl for Qt 5.1)

You tell me all the time yet I can never remember this thing exists :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161215/29366cf8/attachment.html>