[Differential] [Request, 159 lines] D3684: WIP: Media Controls on lock screen

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Thu Dec 15 11:09:40 UTC 2016


broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This provides media controls on the lock screen including album art, track, and title names.

TEST PLAN
  What's to be done:
  
  - Allow to disable this for privacy reasons
  - Crashes when unlocking kscreenlocker_greet in KGlobalAccel after printing QObject::connect: No such slot QObject::_k_shortcutGotChanged(QStringList,QList<int>) (when I don't use kglobalaccel in the Multiplexer in the engine it doesn't crash)
  - Prints a couple of QML warnings when the player exits as the source goes away but since you cannot quit the player from here (and it still ends up hiding the controls then) isn't too bad
  
  Album art, title, artist, controls
  F739728: Screenshot_20161215_115036.png <https://phabricator.kde.org/F739728>
  No album art, no artist, in this case the player name is shown instead
  F739729: Screenshot_20161215_115123.png <https://phabricator.kde.org/F739729>

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3684

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161215/650d0ed5/attachment.html>


More information about the Plasma-devel mailing list