Review Request 125291: WIP proper panel popup positioning in wayland

Marco Martin notmart at gmail.com
Fri Sep 18 12:25:32 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125291/
-----------------------------------------------------------

(Updated Sept. 18, 2015, 12:25 p.m.)


Status
------

This change has been discarded.


Review request for kwin and Plasma.


Repository: plasma-framework


Description
-------

the reason popups and tooltips position themselves some pixels lower than they should is that dialog has a check if the window that shows the item it's positioning relative to is a panel. but is using kwininfo for that, that of course doesn't work on wayland.
currently the patch checks with the metaobject if the qwindow inherits "panelview" and it works, but it's quite horrible.
can't use kwayland from there so don't know a proper way to do it.. maybe will end up exporting some magic property...


Diffs
-----

  src/plasmaquick/dialog.cpp 8d4f508 

Diff: https://git.reviewboard.kde.org/r/125291/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150918/216a6c05/attachment.html>


More information about the Plasma-devel mailing list