Review Request 125295: Fix casting in mouse KCM init

David Edmundson david at davidedmundson.co.uk
Thu Sep 17 20:15:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125295/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-desktop


Description
-------

We fetch 32 bits of data in XIGetProperty

This should be casted into a Bool, which comes from Xlib which is set to
an int (also always 32 bits).

The current code casts it to Bool* which is arch dependent, meaning on
64 bit systems we just read random data.


Diffs
-----

  kcms/input/mouse.cpp c2bd0d0131339d835bf26f5e09768b96875c3142 

Diff: https://git.reviewboard.kde.org/r/125295/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150917/f4ec4fd4/attachment.html>


More information about the Plasma-devel mailing list