Review Request 125291: WIP proper panel popup positioning in wayland

[Thomas Lübking]

> On Sept. 17, 2015, 7:31 nachm., Thomas Lübking wrote:
> > do you intend to test for "QWindow::flags() & Qt::FramelessWindowHint"?
> > (This would cover all unmanaged windows as well as docks and the pseudo-popups/tooltips, plasmashell seems to be so addicted to)
> 
> Thomas Lübking wrote:
>     PS: you oc. want to exclude desktops then, but afair Qt::Desktop matches the root window on X11 - no idea about wayland.
> 
> Marco Martin wrote:
>     I think on x11 is enough to test for dock.
>     
>     on wayland without using kwayland, no idea

Yes, I meant: "platform agnostic and better than checking for panelview".
Right now, you're testing for docks and unmanaged windows on x11, what's pretty close to Qt::FramelessWindowHint (minus the desktop). Since "unmanaged" usually means "popups" but plasma popups are occasionally not and krunner is sometimes a dock and sometiems a normal window, I thought this might be the more general and better match.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125291/#review85586
-----------------------------------------------------------


On Sept. 17, 2015, 4:57 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125291/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 4:57 nachm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> the reason popups and tooltips position themselves some pixels lower than they should is that dialog has a check if the window that shows the item it's positioning relative to is a panel. but is using kwininfo for that, that of course doesn't work on wayland.
> currently the patch checks with the metaobject if the qwindow inherits "panelview" and it works, but it's quite horrible.
> can't use kwayland from there so don't know a proper way to do it.. maybe will end up exporting some magic property...
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 8d4f508 
> 
> Diff: https://git.reviewboard.kde.org/r/125291/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150918/e1fcc24d/attachment.html>